CWE-781

Common consequences1

• IntegrityAvailabilityConfidentialityModify MemoryRead MemoryExecute Unauthorized Code or CommandsDoS: Crash, Exit, or Restart

  If validation is missing or incorrect, an attacker can supply arbitrary memory addresses for memory that belongs to another process or user. If the attacker can control the contents that the IOCTL writes, it may lead to code execution at high privilege levels. At the least, a crash can occur.

Potential mitigations3

1. Implementation

   If METHOD_NEITHER is required for the IOCTL, then ensure that all user-space addresses are properly validated before they are first accessed. The ProbeForRead and ProbeForWrite routines are available for this task. Also properly protect and manage the user-supplied buffers, since the I/O Manager does not do this when METHOD_NEITHER is being used. See References.

2. Architecture and Design

   If possible, avoid using METHOD_NEITHER in the IOCTL and select methods that effectively control the buffer size, such as METHOD_BUFFERED, METHOD_IN_DIRECT, or METHOD_OUT_DIRECT.

3. Architecture and DesignImplementation

   If the IOCTL is part of a driver that is only intended to be accessed by trusted users, then use proper access control for the associated device or device namespace. See References.

Relationships2

• ChildOfCWE-1285
• CanPrecedeCWE-822